cockroachdb / cockroachdb/cockroach

spanconfig: consider deleting `spanconfig.store.fallback_config_override`

Open
#171,408 0 comments 0 reactions 0 assignees View on GitHub
A-configurability A-kv-server A-zone-configs C-cleanup T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

It isn't supported or marked public, but if some a bot or someone found it and messed with it, it could cause some odd/confusing to debug behaviors given it is not commonly used or tested. It might be safer just not having this laying around at all.

(if we do this: we could also delete `RegisterProtobufSetting` and associated code that is used solely for this setting)

Jira issue: CRDB-64513

Contributor guide

Open the contributing guide

Research direction

Search the repository for `spanconfig.store.fallback_config_override` and trace the associated `RegisterProtobufSetting` code. Confirm whether the setting and registration code are used elsewhere, then remove only the unused pieces and run the relevant spanconfig tests to verify the database still builds and passes its checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.