cockroachdb / cockroachdb/cockroach

backup: add metrics for online restore external file ingestion levels

Open
#170,223 2 comments 0 reactions 0 assignees View on GitHub
A-disaster-recovery A-storage C-enhancement O-agent T-disaster-recovery T-storage
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Online restore's LinkExternalSSTable ingestions don't emit any metrics
about which Pebble level files land at. We need per-store counters
tracking ingestion level distribution so LSM shape issues after restore
are visible in Grafana without SSH.

The IngestExternalFiles call in linkExternalSStablePreApply
(pkg/kv/kvserver/replica_proposal.go:808) returns
pebble.IngestOperationStats -- expose the level info as store metrics.

Epic: none.

Jira issue: CRDB-63890

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.