cockroachdb / cockroachdb/cockroach
Eventual cleanup: remove batchingSink and parallelIO
Open
A-cdc
C-enhancement
T-cdc
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
After the no-linger sink has been default for a release or two and any in-flight backports have been retired, `batchingSink` and `parallelIO` become dead code. Maintaining two sink implementations is a tax on every PR touching the Sink interface or `kvevent.Alloc` lifecycle.
Removes `batching_sink.go`, `parallel_io.go`, the `makeBatchingOrNoLingerSink` dispatcher, the `changefeed.no_linger_sink.enabled` cluster setting, and the deprecated metrics. Filed as a follow-up, not committed to as part of this epic.
Related: cockroachdb/cockroach#165386
Jira issue: CRDB-63884
Contributor guide
Assessment
This issue has not been assessed yet.