cockroachdb / cockroachdb/cockroach

kv/kvnemesis: enable DRPC for tests

Open
#170,086 0 comments 0 reactions 0 assignees View on GitHub
branch-master C-enhancement T-db-server
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

The `pkg/kv/kvnemesis` package currently has DRPC explicitly disabled in its `TestMain`:

```go
serverutils.InitTestServerFactory(server.TestServerFactory,
serverutils.WithDRPCOption(base.TestDRPCDisabled),
serverutils.WithTenantOption(base.TestIsSpecificToStorageLayerAndNeedsASystemTenant))
```

This package should be enabled to run with DRPC to ensure coverage of the DRPC code path under kvnemesis's randomized KV workloads.

**Work involved:**
- Change `base.TestDRPCDisabled` to `base.TestDRPCEnabledRandomly` in `pkg/kv/kvnemesis/main_test.go`
- Run tests and investigate any failures under DRPC
- Disable DRPC for individual failing tests if needed while root-causing

Epic: none

Jira issue: CRDB-63821

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.