cockroachdb / cockroachdb/cockroach

roachtest/split: drop qps flavor of load-based split objective tests

Open
#169,442 0 comments 0 reactions 0 assignees View on GitHub
A-kv-distribution C-cleanup O-agent T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Summary:**
`runLoadSplits` ([pkg/cmd/roachtest/tests/split.go:799](https://github.com/cockroachdb/cockroach/blob/master/pkg/cmd/roachtest/tests/split.go#L799)) parameterizes its test cases over `kv.allocator.load_based_rebalancing.objective`, exercising both `qps` and `cpu`. This setting is read only by the legacy `StoreRebalancer` and has no effect under MMA.

MMA only ever balances on CPU, so the `qps` flavor of these tests is dead weight once MMA is the default (per #169430). Drop it; keep CPU coverage only.

**Next Steps:**
- [ ] Remove the `qps` arm of the load-split objective matrix in `split.go`.
- [ ] Drop or simplify the `setLoadBasedRebalancingObjective` helper if it loses its remaining caller.
- [ ] Sanity-check that any related assertions (e.g. expected split counts) still hold under CPU-only.

Epic CRDB-56265

Jira issue: CRDB-63451

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.