cockroachdb / cockroachdb/cockroach

backup: mixed version roachtest never creates a backup schedule

Open
#169,334 1 comment 0 reactions 1 assignee Claimed by @andrew-r-thomas View on GitHub
A-disaster-recovery C-enhancement P-2 T-disaster-recovery
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

The `backup-restore/mixed-version` roachtest creates backups via direct `BACKUP INTO` statements (`planAndRunBackups` registered as `InMixedVersion`), but never uses `CREATE SCHEDULE FOR BACKUP`.

A backup schedule would automatically create incremental backups during the mixed-version upgrade, exercising the scheduled backup code path. This code path is distinct from ad-hoc `BACKUP INTO` and is currently untested in mixed-version environments.

**Relevant code:**
- [Test hook registration](https://github.com/cockroachdb/cockroach/blob/4442354d04be76f56cbbdb06f76894fb3dcf4fbf/pkg/cmd/roachtest/tests/mixed_version_backup.go#L651-L670) — no schedule creation
- [`planAndRunBackups`](https://github.com/cockroachdb/cockroach/blob/4442354d04be76f56cbbdb06f76894fb3dcf4fbf/pkg/cmd/roachtest/tests/mixed_version_backup.go#L324-L330) — uses direct `BACKUP INTO`, not schedules

**Motivation:** This is the same gap identified for LDR in #167156.

Epic: none

Jira issue: CRDB-63394

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.