cockroachdb / cockroachdb/cockroach

cdc: mixed version roachtest never creates changefeed in a mixed-version state

Open
#169,333 1 comment 0 reactions 0 assignees View on GitHub
A-cdc C-enhancement T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

The `cdc/mixed-versions` roachtest registers `createChangeFeed` as an `OnStartup` hook, meaning the changefeed is created on the initial homogeneous cluster before any nodes are upgraded. The test validates that an existing changefeed survives the upgrade, but never tests *creating* a changefeed when nodes are running different binary versions.

The changefeed creation should also be tested `InMixedVersion` to ensure that the creation code path works when the cluster is in a mixed binary state.

**Relevant code:**
- [`OnStartup("start changefeed", ...)`](https://github.com/cockroachdb/cockroach/blob/4442354d04be76f56cbbdb06f76894fb3dcf4fbf/pkg/cmd/roachtest/tests/mixed_version_cdc.go#L599)
- [`createChangeFeed` implementation](https://github.com/cockroachdb/cockroach/blob/4442354d04be76f56cbbdb06f76894fb3dcf4fbf/pkg/cmd/roachtest/tests/mixed_version_cdc.go#L387-L434)

**Motivation:** This is the same gap identified for LDR in #167156.

Epic: none

Jira issue: CRDB-63393

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.