cockroachdb / cockroachdb/cockroach

opt: extend opt-tester framework to mock more non-public schema objects

Open
#169,154 0 comments 0 reactions 1 assignee Claimed by @DrewKimball View on GitHub
C-enhancement T-sql-queries
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

We currently have a way to mark columns in optimizer tests as mutation columns using a special suffix to the column name. This allows us to test invariants required of the optimizer by the schema changer (e.g. don't read from mutation columns) more directly than validating index contents after randomized tests. We should add support for non-public states in other types of schema elements, like indexes. This might have allowed us to more directly test the effect of column pruning rules that lead to https://github.com/cockroachdb/cockroach/issues/166122, and should give us a convenient way to write tests for other invariants once we make them explicit.

Jira issue: CRDB-63290

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.