cockroachdb / cockroachdb/cockroach
logictest: data race around `pebble.(*fileCacheHandle).Metrics` on server shutdown
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
pkg/ccl/logictestccl/tests/local-repeatable-read/local-repeatable-read_test.TestRepeatableReadLogic_inflight_trace_spans [failed](https://mesolite.cluster.engflow.com/invocations/default/358b7ee3-6757-4c33-81d2-ddbbc80e4dc4?testReportRun=2&testReportShard=36&testReportAttempt=1#targets-Ly9wa2cvY2NsL2xvZ2ljdGVzdGNjbC90ZXN0cy9sb2NhbC1yZXBlYXRhYmxlLXJlYWQ6bG9jYWwtcmVwZWF0YWJsZS1yZWFkX3Rlc3Q=) on release-25.2 @ [814e45881c735c6cb5f8872bb2693e7820bba2ce](https://github.com/cockroachdb/cockroach/commits/814e45881c735c6cb5f8872bb2693e7820bba2ce):
```
Goroutine 24834 (running) created at:
github.com/cockroachdb/cockroach/pkg/util/admission.(*StoreGrantCoordinators).SetPebbleMetricsProvider()
pkg/util/admission/grant_coordinator.go:97 +0x5ef
github.com/cockroachdb/cockroach/pkg/server.(*topLevelServer).PreStart()
pkg/server/server.go:1992 +0x4728
github.com/cockroachdb/cockroach/pkg/server.(*testServer).PreStart()
pkg/server/testserver.go:839 +0xe4
github.com/cockroachdb/cockroach/pkg/testutils/serverutils.(*wrap).PreStart()
bazel-out/k8-fastbuild/bin/pkg/testutils/serverutils/ts_control_forwarder_generated.go:19 +0x72
github.com/cockroachdb/cockroach/pkg/testutils/testcluster.(*TestCluster).Start()
pkg/testutils/testcluster/testcluster.go:473 +0x63e
github.com/cockroachdb/cockroach/pkg/testutils/serverutils.StartCluster()
pkg/testutils/serverutils/test_cluster_shim.go:332 +0x10f
github.com/cockroachdb/cockroach/pkg/sql/logictest.(*logicTest).newCluster()
pkg/sql/logictest/logic.go:1609 +0x1211
github.com/cockroachdb/cockroach/pkg/sql/logictest.(*logicTest).setup()
pkg/sql/logictest/logic.go:2021 +0xcbc
github.com/cockroachdb/cockroach/pkg/sql/logictest.RunLogicTest()
pkg/sql/logictest/logic.go:4486 +0xd78
pkg/ccl/logictestccl/tests/local-repeatable-read/local-repeatable-read_test.runLogicTest()
pkg/ccl/logictestccl/tests/local-repeatable-read/generated_test.go:82 +0x124
pkg/ccl/logictestccl/tests/local-repeatable-read/local-repeatable-read_test.TestRepeatableReadLogic_inflight_trace_spans()
pkg/ccl/logictestccl/tests/local-repeatable-read/generated_test.go:1035 +0x59
testing.tRunner()
GOROOT/src/testing/testing.go:1690 +0x226
testing.(*T).Run.gowrap1()
GOROOT/src/testing/testing.go:1743 +0x44
Goroutine 24210 (running) created at:
testing.(*T).Run()
GOROOT/src/testing/testing.go:1743 +0x825
testing.runTests.func1()
GOROOT/src/testing/testing.go:2168 +0x85
testing.tRunner()
GOROOT/src/testing/testing.go:1690 +0x226
testing.runTests()
GOROOT/src/testing/testing.go:2166 +0x8be
testing.(*M).Run()
GOROOT/src/testing/testing.go:2034 +0xf17
pkg/ccl/logictestccl/tests/local-repeatable-read/local-repeatable-read_test.TestMain()
pkg/ccl/logictestccl/tests/local-repeatable-read/generated_test.go:77 +0x2d5
main.main()
bazel-out/k8-fastbuild/bin/pkg/ccl/logictestccl/tests/local-repeatable-read/local-repeatable-read_test_/testmain.go:934 +0x753
runtime.main()
GOROOT/src/runtime/proc.go:272 +0x28a
github.com/cockroachdb/cockroach/pkg/util/parquet.box2DDecoder.decode()
pkg/util/parquet/decoders.go:175 +0x3b
github.com/cockroachdb/cockroach/pkg/util/parquet.init.0()
pkg/util/parquet/decoders.go:402 +0x1d0
==================
```
Parameters:
- attempt=1
- race=true
- run=2
- shard=36
Help
See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)
[This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestRepeatableReadLogic_inflight_trace_spans.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)
Jira issue: CRDB-61553
Contributor guide
Assessment
This issue has not been assessed yet.