cockroachdb / cockroachdb/cockroach

jobs: `ProgressStorage` based jobs incorrectly drop to 0 `fraction_completed` on resume

Open
#164,160 2 comments 0 reactions 1 assignee Claimed by @andrew-r-thomas View on GitHub
A-disaster-recovery C-bug T-disaster-recovery
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Currently, when we resume a job, we call the `JobUpdater` [`started` function](https://github.com/cockroachdb/cockroach/blob/4e667e5c40918fe98297a437eca2d60bc43d4091/pkg/jobs/jobs.go#L243) which internally does a read-modify-write on the job's progress in order to set the trace id. For jobs using the newer `ProgressStorage` api to update progress, this means the job's `fraction_completed` will drop to 0 until the next progress update, as the job's legacy progress field is otherwise unused and contains zero-values.

Jira issue: CRDB-60669

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.