cockroachdb / cockroachdb/cockroach

concurrency: improve lock table verification

Open
#161,786 0 comments 0 reactions 0 assignees View on GitHub
C-enhancement T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

In test builds, we run verification of the lock table on every update. This verification is useful and has helped discover bugs in the lock table.

However, we've recently encountered two problems we might want to address somehow:

1. Under deadlock builds, we've seen failures that _appear_ to be related to lock table verification being very slow.
2. A lock table verification failure can actually happen because of some _other_ request other than the one doing the verification because of how locking works.

For (1), one potential idea is to only run verification after a given proposal has done all of it's lock table updates. This would mean that a request that discovers or updates 10 locks would only have to run verification once rather than 10 times.

Jira issue: CRDB-59084

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.