cockroachdb / cockroachdb/cockroach
observability: review use of gauges for gc metrics
Open
branch-master
C-bug
T-db-server
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
**Describe the problem**
Some of the runtime GC metrics use gauges, but a very quick reading of the code implies they should be counters:
https://github.com/cockroachdb/cockroach/blob/cbe43e5b32873b068ee04b81fd6237be8e53861c/pkg/server/status/runtime.go#L947-L954
Notably:
- GcStopNS
- NonGcPauseNS
- NonGcStopNS
Look suspicious to me.
Jira issue: CRDB-59005
Contributor guide
Assessment
This issue has not been assessed yet.