cockroachdb / cockroachdb/cockroach

ccl/sqlproxyccl: TestCancelQuery failed

Open
#161,165 6 comments 0 reactions 0 assignees View on GitHub
branch-release-24.3.25-rc C-test-failure O-robot T-cloud-platform
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

ccl/sqlproxyccl.TestCancelQuery [failed](https://mesolite.cluster.engflow.com/invocations/default/3ea6743e-8005-40a7-ac47-aa1b11395f5c?testReportRun=2&testReportShard=7&testReportAttempt=1#targets-Ly9wa2cvY2NsL3NxbHByb3h5Y2NsOnNxbHByb3h5Y2NsX3Rlc3Q=) on release-24.3.25-rc @ [eecd7c2c316ed213daab1c664e0d854fc937a746](https://github.com/cockroachdb/cockroach/commits/eecd7c2c316ed213daab1c664e0d854fc937a746):

Fatal error:

```
panic: use of Span after Finish. Span: proxy-con-serve. Finish previously called at: [recovered]
panic: use of Span after Finish. Span: proxy-con-serve. Finish previously called at:

```
Stack:

```
goroutine 4817 [running]:
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).recover(0xc002aaec70?, {0xe3cc618, 0xc007e00c30})
pkg/util/stop/stopper.go:226 +0x74
panic({0xa7695e0?, 0xc00a88cb10?})
GOROOT/src/runtime/panic.go:770 +0x132
github.com/cockroachdb/cockroach/pkg/util/tracing.(*Span).detectUseAfterFinish(0xc00a074008)
pkg/util/tracing/span.go:177 +0x274
github.com/cockroachdb/cockroach/pkg/util/tracing.(*Span).RecordingType(0xc00a074008)
pkg/util/tracing/span.go:437 +0x27
github.com/cockroachdb/cockroach/pkg/util/tracing.(*Span).IsVerbose(...)
pkg/util/tracing/span.go:445
github.com/cockroachdb/cockroach/pkg/util/log.getSpan({0xe3cc4c0, 0xc00a3a2020})
pkg/util/log/trace.go:22 +0x45
github.com/cockroachdb/cockroach/pkg/util/log.logfDepthInternal({0xe3cc4c0, 0xc00a3a2020}, 0x2, 0x3, 0x1, 0x0, {0xaf60150, 0x27}, {0xc00915b698, 0x2, ...})
pkg/util/log/channels.go:99 +0x66b
github.com/cockroachdb/cockroach/pkg/util/log.logfDepth(...)
pkg/util/log/channels.go:34
github.com/cockroachdb/cockroach/pkg/util/log.loggerOps.Errorf(...)
bazel-out/k8-fastbuild/bin/pkg/util/log/log_channels_generated.go:1281
github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl.(*connector).dialTenantCluster(0xc001ad4d80, {0xe3cc4c0, 0xc00a3a2020}, {0xe3cc370, 0xc003ac0d20})
pkg/ccl/sqlproxyccl/connector.go:243 +0xcd8
github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl.(*connector).OpenTenantConnWithToken(0xc001ad4d80, {0xe3cc4c0, 0xc00a3a2020}, {0xe3cc370, 0xc003ac0d20}, {0xc003ee4a00, 0x9c})
pkg/ccl/sqlproxyccl/connector.go:106 +0x1ba
github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl.transferConnection(0xc00a3a2020, {0xe3cc370, 0xc003ac0d20}, 0xc001ad4d80, 0xc00a650000, 0xc005cd7140, 0xc00390d0c8)
pkg/ccl/sqlproxyccl/conn_migration.go:274 +0x40d
github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl.(*forwarder).TransferConnection(0xc003ac0d20)
pkg/ccl/sqlproxyccl/conn_migration.go:213 +0x509
github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl/balancer.(*Balancer).processQueue.func1.1({0xe3cc618, 0xc007e00c30})
pkg/ccl/sqlproxyccl/balancer/balancer.go:371 +0x268
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2({0xaea1077, 0x11})
pkg/util/stop/stopper.go:498 +0x339
created by github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx in goroutine 4752
pkg/util/stop/stopper.go:488 +0x786
```
Log preceding fatal error

```
=== RUN TestCancelQuery
test_log_scope.go:165: test logs captured to: outputs.zip/logTestCancelQuery4205631219
test_log_scope.go:76: use -show-logs to present logs inline
=== RUN TestCancelQuery/ignore_unknown_secret_key
*
* ERROR: a panic has occurred!
* use of Span after Finish. Span: proxy-con-serve. Finish previously called at:
* (1) attached stack trace
* -- stack trace:
* | runtime.gopanic
* | GOROOT/src/runtime/panic.go:770
* | [...repeated from below...]
* Wraps: (2) assertion failure
* Wraps: (3) attached stack trace
* -- stack trace:
* | github.com/cockroachdb/cockroach/pkg/util/tracing.(*Span).detectUseAfterFinish
* | pkg/util/tracing/span.go:177
* | github.com/cockroachdb/cockroach/pkg/util/tracing.(*Span).RecordingType
* | pkg/util/tracing/span.go:437
* | github.com/cockroachdb/cockroach/pkg/util/tracing.(*Span).IsVerbose
* | pkg/util/tracing/span.go:445
* | github.com/cockroachdb/cockroach/pkg/util/log.getSpan
* | pkg/util/log/trace.go:22
* | github.com/cockroachdb/cockroach/pkg/util/log.logfDepthInternal
* | pkg/util/log/channels.go:99
* | github.com/cockroachdb/cockroach/pkg/util/log.logfDepth
* | pkg/util/log/channels.go:34
* | github.com/cockroachdb/cockroach/pkg/util/log.loggerOps.Errorf
* | bazel-out/k8-fastbuild/bin/pkg/util/log/log_channels_generated.go:1281
* | github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl.(*connector).dialTenantCluster
* | pkg/ccl/sqlproxyccl/connector.go:243
* | github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl.(*connector).OpenTenantConnWithToken
* | pkg/ccl/sqlproxyccl/connector.go:106
* | github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl.transferConnection
* | pkg/ccl/sqlproxyccl/conn_migration.go:274
* | github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl.(*forwarder).TransferConnection
* | pkg/ccl/sqlproxyccl/conn_migration.go:213
* | github.com/cockroachdb/cockroach/pkg/ccl/sqlproxyccl/balancer.(*Balancer).processQueue.func1.1
* | pkg/ccl/sqlproxyccl/balancer/balancer.go:371
* | github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2
* | pkg/util/stop/stopper.go:498
* | runtime.goexit
* | src/runtime/asm_amd64.s:1695
* Wraps: (4) use of Span after Finish. Span: proxy-con-serve. Finish previously called at:
* Error types: (1) *withstack.withStack (2) *assert.withAssertionFailure (3) *withstack.withStack (4) *errutil.leafError
*
```

Parameters:
- attempt=1
- race=true
- run=2
- shard=7
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)

Same failure on other branches

- #158242 ccl/sqlproxyccl: TestCancelQuery failed [data race in testing util] [C-test-failure O-robot T-serverless branch-release-25.4.1-rc]
- #151664 ccl/sqlproxyccl: TestCancelQuery failed [C-test-failure O-robot T-serverless branch-release-24.3.19-rc]
- #151651 ccl/sqlproxyccl: TestCancelQuery failed [C-test-failure O-robot T-serverless branch-release-24.1.23-rc]
- #148599 ccl/sqlproxyccl: TestCancelQuery failed [C-test-failure O-robot T-serverless branch-release-24.1]
- #145279 ccl/sqlproxyccl: TestCancelQuery failed [C-test-failure O-robot T-serverless branch-release-25.1]
- #144691 ccl/sqlproxyccl: TestCancelQuery failed [C-test-failure O-robot T-serverless branch-release-24.3]
- #142810 ccl/sqlproxyccl: TestCancelQuery failed [C-test-failure O-robot T-serverless branch-master]

/cc @cockroachdb/sql-foundations @cockroachdb/server

[This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestCancelQuery.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)

Jira issue: CRDB-58719

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.