cockroachdb / cockroachdb/cockroach

changefeedccl: max_behind_nanos metric should be based on highwater

Open
#156,982 2 comments 0 reactions 0 assignees View on GitHub
A-cdc C-bug E-quick-win T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

The `changefeed.max_behind_nanos` gauge metric is currently based on how much an aggregator's local resolved timestamp lags the current time, but its description says "[t]he most any changefeed's persisted checkpoint is behind the present", which seems to imply that it should be actually computed based on the checkpointed highwater timestamp.

Jira issue: CRDB-56330

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.