cockroachdb / cockroachdb/cockroach

changefeedccl: per-table PTS leaks PTS records with multiple column families

Open
#155,957 2 comments 0 reactions 0 assignees View on GitHub
A-cdc branch-master C-bug T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Similar to #154196, there's another failure mode in `changefeedPlanHook` where we'll silently leak PTS records when a table has multiple column families:
https://github.com/cockroachdb/cockroach/blob/1ae7b24a72045978ce91ce0630a615542508e87a/pkg/ccl/changefeedccl/changefeed_stmt.go#L353

We should check if the table is in the map already before creating a new record.

Jira issue: CRDB-55722

Epic CRDB-1421

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.