cockroachdb / cockroachdb/cockroach

changefeedccl: cloudstorage sink file naming may not always be lexicographically ordered

Open
#155,174 3 comments 0 reactions 0 assignees View on GitHub
A-cdc C-bug T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Per https://github.com/cockroachdb/cockroach/issues/155015#issuecomment-3386163179, the cloudstorage sink assumes that every time it's flushed, the changefeed's frontier timestamp has advanced. This isn't always true (e.g. when the feed is lagging and the lag checkpoint code path is hit: https://github.com/cockroachdb/cockroach/blob/94b54b74bdbc45a9aae1e74d463ed4b25e5661ae/pkg/ccl/changefeedccl/changefeed_processors.go#L959-L967) and may have ramifications for making sure that new cloudstorage sink files have names that sort lexicographically after all previously written files.

Jira issue: CRDB-55306

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.