cockroachdb / cockroachdb/cockroach

kvserver: do not return resume spans when ExportRequests run into Elastic CPU limits

Open
#154,884 1 comment 0 reactions 0 assignees View on GitHub
A-admission-control C-enhancement T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**

From a conversation with @tbg, @sumeerbhola, and @wenyihu6 -- As ExportRequests do not hold latches during evaluation, they do not need to return back to the DistSender if they run into limits due to the Elastic CPU limiter. Instead, this can all be handled on the server by having the ExportRequest re-acquire more elastic CPU tokens and resuming evaluation from where it left off.

Jira issue: CRDB-55179

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.