cockroachdb / cockroachdb/cockroach
changefeedccl: audit event allocations to see if we leak them anywhere else
Open
A-cdc
C-enhancement
O-support
P-3
T-cdc
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
We know now that we leak allocs here: https://github.com/cockroachdb/cockroach/issues/154776
It's likely this is not the only way it can happen. We should audit the code to try and ID more.
Another possible one: https://github.com/cockroachdb/cockroach/blob/c3e2217b963cc5db17053b11810a0a8893442f5d/pkg/ccl/changefeedccl/event_processing.go#L420 (in release mode this just warns and doesnt crash us)
Jira issue: CRDB-55113
Contributor guide
Assessment
This issue has not been assessed yet.