cockroachdb / cockroachdb/cockroach
changefeedccl: monitor memory metrics aren't hooked up to metrics infra
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
There are memory metrics for the changefeed monitor introduced in https://github.com/cockroachdb/cockroach/commit/68a32859aa914dc7d7feceaaed97a7ff8fbef245:
https://github.com/cockroachdb/cockroach/blob/d92164ff0d1654fedc1ccb7a280509101cf80226/pkg/ccl/changefeedccl/metrics.go#L1325-L1338
They however aren't hooked up to the metrics infra the way the bulk metrics are (not properly registered), which means the metrics won't show up anywhere:
https://github.com/cockroachdb/cockroach/blob/92fbc0815315b490e70e63cc9a2e0d8e3577f261/pkg/server/server_sql.go#L688-L689
Discovered while investigating https://github.com/cockroachlabs/support/issues/3447
See also #154767
Jira issue: CRDB-55108
Contributor guide
Assessment
This issue has not been assessed yet.