cockroachdb / cockroachdb/cockroach
backup/cdc: reconsider API for ResolveTargetsToDescriptors
Open
A-disaster-recovery
C-enhancement
P-2
T-disaster-recovery
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
Currently, ResolveTargetsToDescriptors [returns](https://github.com/msbutler/cockroach/blob/master/pkg/backup/backupresolver/targets.go#L687) a motley list of objects that have unclear uses.
```
targetDescs, completeDBs, requestedDBs, descsByTablePattern
```
Since we're refactoring this function to use a collection to fetch the target descriptors over in https://github.com/cockroachdb/cockroach/issues/146803, we should consider cleaning up the` ResolveTargetsToDescriptors` to play more nicely with the collection api. I'll need to read a bit more about what exactly we need to return.
Jira issue: CRDB-54957
Epic CRDB-52076
Contributor guide
Assessment
This issue has not been assessed yet.