cockroachdb / cockroachdb/cockroach

logictest: improve testing of system columns

Open
#152,136 0 comments 0 reactions 0 assignees View on GitHub
A-testing C-enhancement E-quick-win T-sql-queries
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Thinking about #151325, we could have identified it sooner if we had better testing of system columns like `crdb_internal_mvcc_timestamp` in our logic test framework. One idea would be to implicitly add some of the system columns to each query and then project the result column away. This would be easiest for `statement ok` directives where we wouldn't even need to project it away. Maybe this should be implemented as a mutator (similar to `columnFamilyMutator`) that would only apply to SELECT stmts.

Jira issue: CRDB-53664

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.