cockroachdb / cockroachdb/cockroach

net: record TCP BBR congestion algorithm stats

Open
#151,213 0 comments 0 reactions 0 assignees View on GitHub
A-cluster-observability A-kv-observability A-server-networking A-sql-observability C-enhancement T-db-server
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

If we enable the BBR congestion control algorithm in Cloud and/or recommend self-hosted clusters use BBR, then we should collect BBR-specific metrics. See [this internal doc](https://docs.google.com/document/d/1QiHVXJCWShzieVY2Fe3tE9VndbVlI3ETgU4s7NPXuJw/edit?tab=t.0) for more details.

These metrics should be relatively easy to access once #149959 is completed:

https://github.com/mikioh/tcpinfo/blob/30a79bb1804bc47fa7fe29928c9109f368792a9e/zsys_linux.go#L97-L103

```
type tcpBBRInfo struct {
Bw_lo uint32
Bw_hi uint32
Min_rtt uint32
Pacing_gain uint32
Cwnd_gain uint32
}
```

We might not need all of these. We should figure out which metrics are best to capture to understand the behavior of BBR in a production cluster.

Jira issue: CRDB-53120

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.