cockroachdb / cockroachdb/cockroach

backup: add marker file in backups for TTL detection

Open
#150,942 3 comments 0 reactions 1 assignee Claimed by @kev-cao View on GitHub
A-disaster-recovery C-enhancement C-wishlist P-3 T-disaster-recovery
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Currently, the manifest file indicates that a backup is complete and restorable. However, taking into consideration bucket TTL policies, this is not necessarily true. The manifest file is the last file written in a backup, which means that the data files will expire before the manifest expires, so it is entirely possible that a backup contains a manifest but is not restorable.

We should write a file at the start of a backup to ensure it expires before all other files and when checking if a backup is restorable, we look for the existence of both the manifest and the file.

Context: https://cockroachlabs.slack.com/archives/C03JCUUSCD6/p1753465882995189

Epic: CRDB-52076

Jira issue: CRDB-53010

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.