cockroachdb / cockroachdb/cockroach

changefeedccl: don't double-wait on non-local node drain

Open
#149,934 1 comment 0 reactions 0 assignees View on GitHub
A-cdc C-enhancement T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

NOTE: none of this is turned on when the changefeed drain watcher is disabled, which it currently is.

Currently when a CA node drains, the changefeed coordinator wait for two backoff times instead of one: https://github.com/massimo-ua/cockroach/blob/1d9d751addbe2bc1e01c973c60bc35bbd96e6165/pkg/ccl/changefeedccl/changefeed_stmt.go#L1564 .
There's no good reason for this and we shouldn't do it.

For reference, ldr & pcr do not handle this at all.

Jira issue: CRDB-52418

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.