cockroachdb / cockroachdb/cockroach

kvserver: improve raft transport metrics

Open
#148,893 1 comment 0 reactions 0 assignees View on GitHub
C-enhancement E-starter T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

We have metrics for the send queue size and whether we're dropping based on the queue size, but we could add additional metrics for the send loop, which only has a "message sent" counter so far:

https://github.com/cockroachdb/cockroach/blob/449f0979bfe993137b206691ce8d81e7969a43ae/pkg/kv/kvserver/raft_transport.go#L689-L726

Concretely, the bytes sent (labeled by target node) and potentially even a histogram of payload sizes, though that is likely overkill.

xref https://github.com/cockroachlabs/support/issues/3342

Jira issue: CRDB-51871

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.