cockroachdb / cockroachdb/cockroach

changefeedccl: sink_errors metric is inaccurate

Open
#148,846 1 comment 0 reactions 0 assignees View on GitHub
A-cdc branch-master C-bug T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

It checks for errors from EmitRow, but many sinks only make requests on Flush or asynchronously. This metric should capture those errors too.

Currently we recommend using the internal_retry_message_count metric instead.

Jira issue: CRDB-51848

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.