cockroachdb / cockroachdb/cockroach

changefeedccl: add tests for ALTER CHANGEFEED that assert on checkpoint content

Open
#148,818 1 comment 0 reactions 0 assignees View on GitHub
A-cdc C-enhancement T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

We currently already have tests that implicitly test that checkpoints are correctly written during ALTER CHANGEFEED by making sure we see the right events afterwards. However, we don't have any tests that actually assert on the content of the checkpoint. If those tests existed, it would've allowed us to catch [this bug](https://github.com/cockroachdb/cockroach/pull/148617#discussion_r2166979005) sooner.

Jira issue: CRDB-51832

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.