cockroachdb / cockroachdb/cockroach
kvcoord: `hasPerformedReadsLocked` doesn't work under RC
Open
branch-release-23.2
C-bug
T-kv
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
When working through #147853, we realized that `HasPerformedReads` doesn't work correctly under RC isolation since the current implementation relies on the span refresh footprint, which isn't a thing under RC. Concretely, it has the following impact:
- SET TRANSACTION AS OF SYSTEM TIME is not rejected on an RC txn that performed reads (#79090)
- `kv.Txn.SetFixedTimestamp`, which is used in many places, doesn't return an error for an RC txn that performed reads.
Jira issue: CRDB-51791
Contributor guide
Assessment
This issue has not been assessed yet.