cockroachdb / cockroachdb/cockroach

import: consider retrying admission control errors

Open
#148,219 1 comment 0 reactions 0 assignees View on GitHub
A-import C-enhancement O-25.2.1-scale-testing O-testcluster P-3 T-sql-foundations
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

On 25.2.1 scale test IMPORT of one of the TPCC tables hit an error that failed the job:
```
deadline expired while waiting in queue: sql-sql-response, pri: normal-pri, deadline: 0001-01-01 00:00:00 +0000 UTC, start: 2025-06-12 15:57:34.04442544 +0000 UTC m=+93856.281045455, dur: 8.15101981s
```
We should consider retrying such errors that come from the admission control.

The error itself is a bit misleading - there was no deadline on this request to be admitted; instead, `context.Context` seems to have been canceled which effectively aborted the request that IMPORT issued.

The fix might be as simple as including this error (perhaps other from AC system as well) into `joberror.IsPermanentBulkJobError`.

Jira issue: CRDB-51484

Epic CRDB-62881

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.