cockroachdb / cockroachdb/cockroach

roachtest: leaked goroutines

Open
#148,196 2 comments 0 reactions 0 assignees View on GitHub
A-testeng-foundations A-testing branch-master C-bug T-testeng
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Roachtest [prints](https://github.com/cockroachdb/cockroach/blob/2c99066211911e14c7519ec47a5c021488a1fe71/pkg/cmd/roachtest/run.go#L155-L160) leaked goroutines after successful completion.

I'm disabling this in https://github.com/cockroachdb/cockroach/pull/146990 since the leak check has been there for going on two years and few, if any, of the leaks were fixed. Dumping pages of leaked goroutines after each roachtest run is detrimental to the UX of the tool.

TE should re-enable this check only when actually preparing to cut down on the leaked goroutines. Understandably, this hasn't been a priority, and would likely regress unless coupled with some enforcement on a per-test level.

Jira issue: CRDB-51467

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.