cockroachdb / cockroachdb/cockroach

logictestccl: move CCL logic tests into sql/logictest

Open
#147,830 0 comments 0 reactions 0 assignees View on GitHub
A-testing C-cleanup T-sql-queries
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

We no longer need to maintain CCL logic tests separately from core logic tests, and it causes confusion when some features are not available in sql/logictest (such as Read Committed isolation). We should:

- [ ] make all CCL features available in sql/logictest
- [ ] move all tests from ccl/logictestccl into sql/logictest

Jira issue: CRDB-51272

Contributor guide

Open the contributing guide

Research direction

Compare ccl/logictestccl with sql/logictest and identify the CCL features currently unavailable in sql/logictest. Move the existing tests into sql/logictest while preserving coverage, then verify that all CCL features and migrated logic tests work there and that the separate test location is no longer needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.