cockroachdb / cockroachdb/cockroach

sstbatcher: improve API

Open
#146,825 1 comment 0 reactions 0 assignees View on GitHub
A-disaster-recovery C-enhancement O-postmortem P-3 T-disaster-recovery
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

The SST batcher API should be simplified to:

```
type BulkSSTAddr interface {
BufferRow(ctx, row) error
// Optionally flush the local buffer and wait for in flight work to complete.
Flush(ctx) error
// Flush then release local resources.
Close(ctx) error
}
```

https://cockroachlabs.slack.com/archives/C03JCUUSCD6/p1746727527321749

Jira issue: CRDB-50731

Epic CRDB-50860

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.