cockroachdb / cockroachdb/cockroach
catalog/lease: improve orphaned lease testing on multitenant
Open
A-testing
branch-master
C-enhancement
T-sql-foundations
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
Currently, our testing for orphaned leases is limited to artificially inserting sessions into the system.lease table (https://github.com/cockroachdb/cockroach/blob/0d06a203a6ac6752ce2173d64c4fe048d7a8c314/pkg/sql/catalog/lease/lease_test.go#L1763), while this is a good unit test, its an approximation of the real world scenario. As an end to end test, we should have a test that repeatedly stop and starts a tenant and confirm that leases are properly cleaned up.
Jira issue: CRDB-50712
Epic CRDB-60956
Contributor guide
Assessment
This issue has not been assessed yet.