cockroachdb / cockroachdb/cockroach
kvcoord: annotate Refresh failures with ConflictingTxn info
Open
branch-master
C-enhancement
E-starter
T-kv
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
**Describe the problem**
When a batch hits a serialisation error and the (non-preemptive) refresh fails, we propagate the original error.
https://github.com/cockroachdb/cockroach/blob/d99138e2735966b46140fdec9f560306a7b2d282/pkg/kv/kvclient/kvcoord/txn_interceptor_span_refresher.go#L330-L334
It would be nice if we attached the information about the conflict that almost surely exists in the `refreshErr` to the error we return so it is available to other observability surfaces in the database.
Jira issue: CRDB-50685
Contributor guide
Assessment
This issue has not been assessed yet.