cockroachdb / cockroachdb/cockroach

storage: update tests after value separation enabled by default

Open
#146,666 0 comments 0 reactions 0 assignees View on GitHub
A-storage C-enhancement T-storage
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

We have some tests that have been manually tuned with certain expectations of bandwidth driven by a workload. With value separation our bandwidth expectations will change. We should revisit these tests.

- [ ] The roachtest created for https://github.com/cockroachdb/cockroach/issues/146095 will be dependent on the workload generating a certain bandwidth.

Jira issue: CRDB-50646

Contributor guide

Open the contributing guide

Research direction

Start with the roachtest created for issue 146095 and inspect how its workload produces and checks bandwidth. Review the affected bandwidth expectations in light of value separation being enabled by default. Done means the tests use expectations that match the revised workload bandwidth.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.