cockroachdb / cockroachdb/cockroach

kvserver: add per-tenant metric counter for replica cpu usage

Open
#146,449 0 comments 0 reactions 0 assignees View on GitHub
C-enhancement O-support P-3 T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

It would be useful to know how much (go scheduled) CPU time each tenant is using on a kvserver. Currently, we record a replica's time spent on-processor, processing batch requests and processing raft work.

This issue is to add a new counter metric, which records the cumulative CPU time from:

https://github.com/cockroachdb/cockroach/blob/bae6788db4560cec9be77baa4efa1bcfcdc48a0c/pkg/kv/kvserver/replica.go#L2759-L2761

and

https://github.com/cockroachdb/cockroach/blob/bae6788db4560cec9be77baa4efa1bcfcdc48a0c/pkg/kv/kvserver/replica.go#L2767-L2769

This metric should be per-tenant, see [here](https://github.com/cockroachdb/cockroach/blob/bae6788db4560cec9be77baa4efa1bcfcdc48a0c/pkg/kv/kvserver/metrics.go#L3118-L3118).

cc https://github.com/cockroachlabs/support/issues/3297

Jira issue: CRDB-50530

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.