cockroachdb / cockroachdb/cockroach

Webhook servers used in roachtests should check for ordering guarantees using resolved timestamps and event timestamps

Open
#146,097 1 comment 0 reactions 0 assignees View on GitHub
A-cdc C-enhancement T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

The test webhook servers in cockroachdb/cockroach/pkg/workload/debug/webhook_server_slow.go and cockroachdb/cockroach/pkg/workload/debug/webhook_server.go are used in two roachtests that make sure changefeeds work when nodes are frequently restarted.

Right now these tests only check that these sinks received all the messages they expected. They do not verify that they come through in the right order or respect resolved timestamps. We should add this to give us more test coverage.

Attaching this issue to a TODO that was already in a comment.

Jira issue: CRDB-50387

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.