cockroachdb / cockroachdb/cockroach

*: consider adopting HashTrieMap (go1.24) over

Open
#143,363 1 comment 0 reactions 0 assignees View on GitHub
C-investigation o-perf-efficiency P-3 T-sql-queries
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

In 2017, we [forked sync.Map](https://github.com/cockroachdb/cockroach/pull/17625) to improve its performance. Eventually we [made it generic](https://github.com/cockroachdb/cockroach/pull/120604).

In go1.24, there's a new game in town: https://github.com/golang/go/issues/70683. It's not generic, but it's worth a look anyway since it appears to be significantly faster compared to the previous upstream `sync.Map` implementation.

We could see how difficult it would be to copy this implementation over and make it a replacement for our semi-homegrown sync.Map.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.