cockroachdb / cockroachdb/cockroach

kvserver: remove explicit TransitionFromSharedToRegularReplicate

Open
#142,673 0 comments 0 reactions 0 assignees View on GitHub
C-cleanup T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

See https://github.com/cockroachdb/cockroach/pull/142476.

When sending a snapshot that may contain shared SSTs, we can end up realizing that the shared SSTs are not available and will send an explicit "transition" snapshot message. At this point, it seems unnecessary to do so since the recipient has built up no state that it needs to clear.

We should remove this explicit transition.

Jira issue: CRDB-48468

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.