cockroachdb / cockroachdb/cockroach
tenantcostclient: add metric for amount of time blocked by the tenant cost client limiter
Open
A-multitenancy
C-enhancement
E-quick-win
O-support
P-3
T-sql-queries
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
There is an existing metric that measures the number of KV requests that blocked waiting for the tenant cost client limiter: `tenant.cost_client.blocked_requests`. It would be nice to also add a metric that counts the time those requests waited for.
Jira issue: CRDB-48448
Contributor guide
Research direction
Locate the existing tenant.cost_client.blocked_requests metric and the tenant cost client limiter code that records blocked KV requests. Trace how wait time is measured, then add the corresponding wait-time metric and verify that it reports the time requests spend waiting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- databases, observability
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100