cockroachdb / cockroachdb/cockroach
changefeedccl: enable default collation locale in TestAvroSchema
Open
A-cdc
branch-release-23.2
branch-release-24.1
branch-release-24.3
branch-release-25.1
branch-release-25.2
C-bug
T-cdc
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
Of the CRDB-specific collation locales ("default", "C", "POSIX"), only "default" is allowed when creating columns and therefore only "default" is relevant in changefeed testing. In TestAvroSchema, however, when there are columns with the "default" locale the test panics due to being unable to parse the string: https://github.com/cockroachdb/cockroach/blob/032e1be4b4caf8f55bef8e7503eeb99e3edf5416/pkg/sql/sem/tree/datum.go#L1343
We should fix the test or the way the locales are parsed so we can reenable "default".
Jira issue: CRDB-47274
Contributor guide
Assessment
This issue has not been assessed yet.