cockroachdb / cockroachdb/cockroach

storage: randomized testing of error propagation

Open
#139,746 1 comment 0 reactions 0 assignees View on GitHub
A-storage C-cleanup T-storage
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Read errors are unlikely in modern local filesystems, and it's suspected that the error propagation codepaths in pkg/storage's EngineIterator and MVCCIterator are infrequently exercised. When external sstables are in use (ie, during online restore), ephemeral errors are more likely to occur. If these errors are not propagated, they can result in silently incorrect results. Randomized testing of the pkg/storage iterators' error propagation would help shake out any instances where we do not propagate ephemeral errors.

#123478 is related.

Jira issue: CRDB-46796

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.