cockroachdb / cockroachdb/cockroach

changefeedccl: Remove "ugly hack" from nemesis tests

Open
#139,035 1 comment 0 reactions 0 assignees View on GitHub
A-cdc C-enhancement T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Is your feature request related to a problem? Please describe.**
In order to disable behavior for certain sinks in nemesis tests we string match against the name of the test.
```
// TODO(dan): Ugly hack to disable `eventPause` in sinkless feeds.
isSinkless := strings.Contains(testName, "sinkless")
```

**Describe the solution you'd like**
We should put multiple tests in nemeses_test.go, one for each sink, and then manually pass in the sink values to nemesis.

Jira issue: CRDB-46483

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.