cockroachdb / cockroachdb/cockroach

server: enhance _status/NetworkConnectivity for external-process mode

Open
#138,156 0 comments 0 reactions 0 assignees View on GitHub
C-enhancement T-observability
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

This is a follow-up of the PR https://github.com/cockroachdb/cockroach/pull/131830. The PR description is self-explanatory, but for completeness, I'll summarize it here.

With https://github.com/cockroachdb/cockroach/pull/131830, `_status/NetworkConnectivity` is now enabled for secondary tenants in both shared and external process modes. This works well for shared-process mode where inter-node network connectivity for a secondary tenant is the same as for the system tenant. However, in external-process mode, this endpoint won't provide a complete picture of network connectivity since the SQL server may run entirely outside the KV node. As a result, this endpoint only shows KV-KV nodes network connectivity so it isn't ready for external-process mode. We may need to extend this or create a new endpoint for SQL-SQL servers and SQL server to KV nodes.

Jira issue: CRDB-45934

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.