cockroachdb / cockroachdb/cockroach

cloud: add timeout to all implementations of `ReadFile`

Open
#137,854 2 comments 0 reactions 0 assignees View on GitHub
A-disaster-recovery C-wishlist P-3 T-disaster-recovery
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

In a recent escalation, `ReadFile` hung indefinitely (several days) because the gcs sdk retried connecting to the metadata service indefinitely. Since `ReadFile` merely returns a reader at the provided file offset, it seems reasonable to add a hard timeout after a couple minutes.

Jira issue: CRDB-45773

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.