cockroachdb / cockroachdb/cockroach

admission: improve descriptions of metrics in the admission pkg

Open
#137,357 0 comments 0 reactions 0 assignees View on GitHub
A-admission-control C-enhancement E-starter T-admission-control
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

We a few fair share of metrics with vague descriptions. We should add a bit more to allow the consumer of those metrics understand what exactly the metric represents.

Even though a majority of these metrics are meant to be internal, better descriptions will help other engineers and PMs know what it is.

Example:
`admission.requested.kv-stores.high-pri` -> "Number of requests". This could likely say something along the lines of "Total number of requests for admission to the store work queue".

cc @dshjoshi

Jira issue: CRDB-45539

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.