cockroachdb / cockroachdb/cockroach
cli/testdata/doctor: make tested output more specific
Open
C-bug
E-quick-win
T-sql-foundations
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
Currently the tests in this package compare the entire output of running doctor which enumerates every single table in the zip, making these tests overly broad in what they assert and brittle. See https://cockroachlabs.atlassian.net/wiki/spaces/CRDB/pages/181371303/Go+Golang+coding+guidelines#Scope-of-Tested-Behavior.
These tests should be updated to more narrowly assert the behavior they test, and verify only the output relevant to specific, deliberately chosen tables.
Jira issue: CRDB-45365
Epic CRDB-48808
Contributor guide
Assessment
This issue has not been assessed yet.