cockroachdb / cockroachdb/cockroach

ci: consider not running `nogo` as part of builds in certain jobs (roachtests, nightlies, etc.)

Open
#136,626 1 comment 0 reactions 1 assignee Assigned to @rickystewart View on GitHub
A-ci C-enhancement T-dev-inf
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Generally, CI jobs and automation (including roachtests, nightlies, etc.) build with `--config ci` which implies `--config lintonbuild`. This can slow down the build a fair amount and for many jobs (especially nightlies or other post-merge jobs), this extra validation is totally unnecessary.

It's unclear right now how to fix this, but one option we have is decoupling `lintonbuild` from `--config ci`. These days, `--run_validations` (which is what is used for `nogo` in `rules_go`) defaults to `true`, so omitting the command-line flag by itself will not be sufficient. We will instead have to add `--norun_validations` wherever we don't want `nogo` running.

Jira issue: CRDB-45172

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.