cockroachdb / cockroachdb/cockroach
changefeedccl: incorrect metric types
Open
A-cdc
branch-master
C-bug
E-easy
E-quick-win
O-24.3-scale-testing
O-testcluster
P-2
T-cdc
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
`cockroachdb.changefeed.internal_retry_message` is a gauge, but it should be a counter. This causes the datadog integration to be annoying (have to use derivative instead of native rate, and no `count` available)
`changefeed.batch_reduction_count` is also affected, and possibly others
Is changing the type of these metrics a breaking change? Can we do it in a way without breaking the datadog integration? I'm not sure.
Jira issue: CRDB-44128
Contributor guide
Assessment
This issue has not been assessed yet.