cockroachdb / cockroachdb/cockroach

ui: transactions page - transaction query column partial txn queries not being displayed when there are missing statements

Open
#133,995 1 comment 0 reactions 0 assignees View on GitHub
C-bug T-observability
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

To construct transaction query text, we map the txn's stmt fingerprints to their queries. Sometimes, we won't be able to find a statement for a txn. This leads to 2 issues:

1. By the transaction text, there's no way to tell if a stmt's query was skipped. We might want to add a placeholder text indicating that.
2. When constructing the transaction query text column, [we limit the text](https://github.com/cockroachdb/cockroach/blob/d5f328ea6f3efd8fbe631c97d59f7b74307d22f9/pkg/ui/workspaces/cluster-ui/src/transactionsTable/transactionsCells/transactionsCells.tsx#L62-L66) shown to 200 characters. When we construct the txn step mentioned previously, we join each stmt query with a newline character. Due to missing statements, we may truncate the text to only whitespace if the first N queries are missing (see photo below as an example). Addressing 1 would fix this. We can ensure that missing queries don't produce newline characters.

image

Jira issue: CRDB-43855

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.